Re: [PATCH] uapi: fix linux/kexec.h userspace compilation errors

From: Dmitry V. Levin
Date: Wed Feb 22 2017 - 21:17:13 EST

On Thu, Feb 23, 2017 at 02:37:46PM +1300, Eric W. Biederman wrote:
> "Dmitry V. Levin" <ldv@xxxxxxxxxxxx> writes:
> > Include <stddef.h> (guarded by #ifndef __KERNEL__) to fix the following
> > linux/kexec.h userspace compilation errors:
> >
> > /usr/include/linux/kexec.h:53:2: error: unknown type name 'size_t'
> > size_t bufsz;
> > /usr/include/linux/kexec.h:55:2: error: unknown type name 'size_t'
> > size_t memsz;
> Were these failures generated with a static checker?

Yes, with
gcc -S -o/dev/null -xc /dev/null -include /usr/include/linux/kexec.h

> What changed that you are seeing new failures in old essentially static
> headers?

Every uapi header file should be standalone, i.e. it must include,
directly or indirectly, every definition it uses, so that no user
should have to guess header dependencies.

It's not the first time I'm seeing this compilation error,
but now I've got some time to submit a fix. Better late than never.


Attachment: pgpvsZJtjsFrj.pgp
Description: PGP signature