Re: [PATCHv7 2/8] printk: rename nmi.c and exported api
From: Sergey Senozhatsky
Date: Thu Feb 23 2017 - 03:12:23 EST
On (02/23/17 08:50), Geert Uytterhoeven wrote:
> Hi Sergey,
> > -config NMI_LOG_BUF_SHIFT
> > - int "Temporary per-CPU NMI log buffer size (12 => 4KB, 13 => 8KB)"
> > +config PRINTK_SAFE_LOG_BUF_SHIFT
> > + int "Temporary per-CPU printk log buffer size (12 => 4KB, 13 => 8KB)"
> > range 10 21
> > default 13
> > - depends on PRINTK_NMI
> > + depends on PRINTK
> Was this dependency change intentional?
> My platform doesn't have PRINTK_NMI.
yes. printk-safe uses the same mechanism as printk-nmi (per-CPU buffers, etc.)
and does not depend on HAVE_NMI/PRINTK_NMI, but depends on PRINTK.
NMI related part of printk-safe (printk-nmi per-CPU buffers, etc.) is not
compiled for !HAVE_NMI systems (since PRINTK_NMI is unset there).