Re: [PATCH v3 4/4] iio: accel: adxl345: Add SPI support
From: Andy Shevchenko
Date: Thu Feb 23 2017 - 11:46:28 EST
On Wed, Feb 22, 2017 at 12:23 PM, Eva Rachel Retuya <eraretuya@xxxxxxxxx> wrote:
> Add SPI driver that initializes SPI regmap for the adxl345 core driver.
> The driver supports the same functionality as I2C namely the x, y, z and
> scale readings.
> --- a/drivers/iio/accel/Kconfig
> +++ b/drivers/iio/accel/Kconfig
> @@ -8,20 +8,26 @@ menu "Accelerometers"
> config ADXL345
> tristate "Analog Devices ADXL345 3-Axis Digital Accelerometer Driver"
> depends on !(INPUT_ADXL34X=y || INPUT_ADXL34X=m)
> + depends on (I2C || SPI)
> select REGMAP
> select ADXL345_I2C if I2C
> + select ADXL345_SPI if SPI
> Say Y here if you want to build support for the Analog Devices
> ADXL345 3-axis digital accelerometer.
> To compile this driver as a module, choose M here: the core
> module will be called adxl345_core and you will also get
> - adxl345_i2c for I2C.
> + adxl345_i2c for I2C and/or adxl345_spi for SPI.
> config ADXL345_I2C
> select REGMAP_I2C
> +config ADXL345_SPI
> + tristate
> + select REGMAP_SPI
I saw another pattern
Library / core part is non-visible to user, while
SPI and I2C parts are selectable by user.
Why do you use inverted pattern? What did I miss?
With Best Regards,