Re: [PATCH] checkpatch: don't complain on module_param(foo, bar, 0)
From: Andy Shevchenko
Date: Thu Feb 23 2017 - 17:10:59 EST
On Thu, Feb 9, 2017 at 2:05 AM, Brian Norris <briannorris@xxxxxxxxxxxx> wrote:
> The following code snippet:
> module_param(writeable, bool, 0);
> yields this warning:
> ERROR: Use 4 digit octal (0777) not decimal permissions
> #390: FILE: drivers/mtd/spi-nor/intel-spi.c:143:
> +module_param(writeable, bool, 0);
> total: 1 errors, 0 warnings, 1006 lines checked
> But 0000 is no easier to read than 0, and module_param() even
> specifically refers to 0.
While this is all correct, the question is why we disallow to read
back on those parameters?
With Best Regards,