Re: [PATCH 4/8] drm/sun4i: add support for sun8i DE2 mixers and display engines
From: Maxime Ripard
Date: Thu Feb 23 2017 - 19:50:05 EST
On Thu, Feb 23, 2017 at 05:44:54PM +0000, Emil Velikov wrote:
> On 22 February 2017 at 15:18, Icenowy Zheng <icenowy@xxxxxxxx> wrote:
> > Allwinner have a new "Display Engine 2.0" in there new SoCs, which comes
> > in a new "Display Engine" (mixers instead of old backends and
> > frontends).
> > Add support for the mixer on Allwinner V3s SoC; it's the simplest one.
> > Signed-off-by: Icenowy Zheng <icenowy@xxxxxxxx>
> > ---
> > drivers/gpu/drm/sun4i/Kconfig | 8 +
> > drivers/gpu/drm/sun4i/Makefile | 1 +
> > drivers/gpu/drm/sun4i/sun4i_crtc.c | 6 +-
> > drivers/gpu/drm/sun4i/sun4i_drv.c | 38 +++-
> > drivers/gpu/drm/sun4i/sun4i_drv.h | 1 +
> > drivers/gpu/drm/sun4i/sun4i_layer.c | 92 ++++++--
> > drivers/gpu/drm/sun4i/sun4i_layer.h | 1 +
> > drivers/gpu/drm/sun4i/sun8i_mixer.c | 417 ++++++++++++++++++++++++++++++++++++
> > drivers/gpu/drm/sun4i/sun8i_mixer.h | 133 ++++++++++++
> > 9 files changed, 674 insertions(+), 23 deletions(-)
> Silly question:
> Does this series cover the same functionality/hardware as the separate
> sun8i driver proposed a few months back ?
> The diff stat looks quite different (~1.6k vs ~0.6k), although that
> could be due to reusing the existing sun4i code.
Since those aren't feature equivalent, this is a bit complicated to
answer, but most of the changes introduced by the old driver was
duplication of code that was already existing (Allwinner TCON, TV
Encoder, Designware HDMI, etc).
This patchset superseeds it by using what is already supported without
the duplication. It also has a bit less features (for example the HDMI
support is missing for now), but it's a much better code base to base
our future work on.
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
Description: PGP signature