Re: [Outreachy kernel] [PATCH] staging: iio: accel: Move header file content to source file

From: Julia Lawall
Date: Mon Feb 27 2017 - 17:06:21 EST


> diff --git a/drivers/staging/iio/accel/adis16201_core.c b/drivers/staging/iio/accel/adis16201_core.c
> index 7963d4a..210699e 100644
> --- a/drivers/staging/iio/accel/adis16201_core.c
> +++ b/drivers/staging/iio/accel/adis16201_core.c
> @@ -20,7 +20,150 @@
> #include <linux/iio/buffer.h>
> #include <linux/iio/imu/adis.h>
>
> -#include "adis16201.h"
> +#ifndef SPI_ADIS16201_H_
> +#define SPI_ADIS16201_H_

I guess you wouldn't need the ifndef and define in the C file? This is
usually used to guard against including a header file more than once.

julia