Re: [PATCH] hid: usbhid: usbkbd: fix checkpatch.pl issues

From: Avraham Shukron
Date: Wed Mar 01 2017 - 15:39:16 EST


>
> This kind of change is definitely not helpful. The original table was
> Nx16, you converted it to Nx14. Why do you think original table used 16
> columns?
>
> Regardless, it's a very old driver, just let it be.
>
> Thanks.
>

I can make it Nx8 :)

Seriously now - I don't understand what is so wrong with checkpatch fixes?
I'm a new to kernel development, and the natural place to start is to do some
coding style fixes.
I thought fixing a driver that I actually use daily will be more satisfying.
Why driver being old is a good reason to ignore the coding style conventions?