RE: [PATCH] Drivers: hv: util: move waiting for release to hv_utils_transport itself

From: Dexuan Cui
Date: Thu Mar 02 2017 - 07:42:58 EST


> From: Vitaly Kuznetsov [mailto:vkuznets@xxxxxxxxxx]
> Sent: Thursday, March 2, 2017 17:48
> To: devel@xxxxxxxxxxxxxxxxxxxxxx
> Cc: linux-kernel@xxxxxxxxxxxxxxx; KY Srinivasan <kys@xxxxxxxxxxxxx>; Haiyang
> Zhang <haiyangz@xxxxxxxxxxxxx>; Stephen Hemminger
> <sthemmin@xxxxxxxxxxxxx>; Dexuan Cui <decui@xxxxxxxxxxxxx>; Alex Ng (LIS)
> <alexng@xxxxxxxxxxxxx>
> Subject: [PATCH] Drivers: hv: util: move waiting for release to hv_utils_transport
> itself
>
> Waiting for release_event in all three drivers introduced issues on release
> as on_reset() hook is not always called. E.g. if the device was never
> opened we will never get the completion.
>
> Move the waiting code to hvutil_transport_destroy() and make sure it is
> only called when the device is open. hvt->lock serialization should
> guarantee the absence of races.
>
> Fixes: 5a66fecbf6aa ("Drivers: hv: util: kvp: Fix a rescind processing issue")
> Fixes: 20951c7535b5 ("Drivers: hv: util: Fcopy: Fix a rescind processing issue")
> Fixes: d77044d142e9 ("Drivers: hv: util: Backup: Fix a rescind processing issue")
> Reported-by: Dexuan Cui <decui@xxxxxxxxxxxxx>
> Tested-by: Dexuan Cui <decui@xxxxxxxxxxxxx>
> Signed-off-by: Vitaly Kuznetsov <vkuznets@xxxxxxxxxx>

Acked-by: Dexuan Cui <decui@xxxxxxxxxxxxx>