Re: [PATCH] module: set __jump_table alignment to 8

From: Steven Rostedt
Date: Thu Mar 02 2017 - 12:45:33 EST


On Thu, 02 Mar 2017 22:18:30 +1100
Michael Ellerman <mpe@xxxxxxxxxxxxxx> wrote:

> Michael Ellerman <mpe@xxxxxxxxxxxxxx> writes:
> > David Daney <david.daney@xxxxxxxxxx> writes:
> >> Strict alignment became necessary with commit 3821fd35b58d
> >> ("jump_label: Reduce the size of struct static_key"), currently in
> >> linux-next, which uses the two least significant bits of pointers to
> >> __jump_table elements.
> >
> > It would obviously be nice if this could go in before the commit that
> > exposes the breakage, but I guess that's problematic because Steve
> > doesn't want to rebase the tracing tree.
> >
> > Steve I think you've already sent your pull request for this cycle? So I
> > guess if this can go in your first batch of fixes?
>
> Ugh. Was looking at the wrong tree - Linus has already merged the commit
> in question, so the above is all moot.

No problem. I've got some other "fixes" to push to Linus. That's what
the -rc releases are for. To fix up breakage from the merge window ;-)

I'll pull this into my tree.

Thanks!

-- Steve