Re: [PATCH] staging: speakup: replace simple_strtoul with kstrtou8

From: Marcin Ciupak
Date: Fri Mar 03 2017 - 03:39:02 EST


On Thu, Mar 02, 2017 at 04:17:12PM +0100, Samuel Thibault wrote:
> Marcin Ciupak, on jeu. 02 mars 2017 15:28:23 +0100, wrote:
> > - int val;
> > + int ret;
> >
> > - val = simple_strtoul(skip_spaces(start), &start, 10);
> > + ret = kstrtou8(skip_spaces(start), 10, dest);
>
> This is not the same, you need to have start properly move, since it's
> used below:
>
> > if (*start == ',')
> > start++;
> > - *dest = (u_char)val;
> > return start;
>
> Samuel

You are right, start is not updated by kstrtou8 like it is by
simple_strtoul.

If I understand it correctly simple_strtoul cannot be replaced by
kstrtou8 here.

Please discard this patch.

Marcin