Re: [PATCH] x86/fpu: fix boolreturn.cocci warnings

From: Ingo Molnar
Date: Tue Mar 07 2017 - 02:33:47 EST



* kbuild test robot <fengguang.wu@xxxxxxxxx> wrote:

> arch/x86/kernel/fpu/xstate.c:931:9-10: WARNING: return of 0/1 in function 'xfeatures_mxcsr_quirk' with return type bool
>
> Return statements in functions returning bool should use
> true/false instead of 1/0.

Note that this is a totally bogus warning. I personally find a 0/1 return more
readable than a textual 'true/false', even if bools are used, and nowhere does the
kernel mandate the use of 0/1.

So NAK ...

Thanks,

Ingo