Re: [PATCH 2/2] x86/head_64.S: Pass struct boot_params' virtual address to C

From: Borislav Petkov
Date: Tue Mar 07 2017 - 05:51:30 EST


On Tue, Mar 07, 2017 at 10:11:40AM +0100, Ingo Molnar wrote:
> The updated comments and other details are fine, but I'm not sure about the __va()
> change: the patch essentially open codes __va() in assembly - which would make any
> changes to __va() [for whatever reason] more difficult, right?
>
> Right now we don't seem to have a single such line of assembly, so changes to
> __va() can be done in C alone.

Ok, that's a fair point.

--
Regards/Gruss,
Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.