Re: [PATCH 1/2] x86/efi: Correct a tiny mistake in code comment

From: Borislav Petkov
Date: Wed Mar 08 2017 - 04:37:14 EST

On Wed, Mar 08, 2017 at 05:09:55PM +0800, Baoquan He wrote:
> Yes, it looks better. I can repost with this change. Thanks.

No it doesn't:

#define EFI_VA_START ( -4 * (_AC(1, UL) << 30))
#define EFI_VA_END (-68 * (_AC(1, UL) << 30))

That's -4G (the shift by 30) and -68G, respectively.

> > #define EFI_VA_START _AC(0xfffffffeffffffff, UL)
> > #define EFI_VA_END _AC(0xffffffef00000000, UL)

That is something which I need to type into a calculator first.

Can you guys point your attention to something which is really broken
and stop wasting your time? And there's enough really broken crap left
and right...


Good mailing practices for 400: avoid top-posting and trim the reply.