Re: [tip:x86/asm] x86/asm: Optimize clear_page()

From: Ingo Molnar
Date: Wed Mar 08 2017 - 06:57:47 EST



* Yinghai Lu <yinghai@xxxxxxxxxx> wrote:

> On Mon, Mar 6, 2017 at 11:30 PM, Ingo Molnar <mingo@xxxxxxxxxx> wrote:
> >
> > * Yinghai Lu <yinghai@xxxxxxxxxx> wrote:
> >
> >> On Wed, Mar 1, 2017 at 1:47 AM, tip-bot for Borislav Petkov
> >> <tipbot@xxxxxxxxx> wrote:
> >> > Commit-ID: 49ca7bb328c630dd43be626534b49e19513296fd
> >> > Gitweb: http://git.kernel.org/tip/49ca7bb328c630dd43be626534b49e19513296fd
> >> > Author: Borislav Petkov <bp@xxxxxxx>
> >> > AuthorDate: Thu, 9 Feb 2017 01:34:49 +0100
> >> > Committer: Ingo Molnar <mingo@xxxxxxxxxx>
> >> > CommitDate: Wed, 1 Mar 2017 10:18:32 +0100
> >> >
> >> > x86/asm: Optimize clear_page()
> >> >
> >> > Currently, we CALL clear_page() which then JMPs to the proper function
> >> > chosen by the alternatives.
> >> >
> >> > What we should do instead is CALL the proper function directly. (This
> >> > was something Ingo suggested a while ago). So let's do that.
> >>
> >> looks like this one broke the kexec.
> >> after revert it back, kexec work again.
> >
> > Ok, this should be fixed in the new version I just pushed out:
> >
> > f25d38475519 x86/asm: Optimize clear_page()
> >
> > Please let me know if it doesn't.
>
> Yes. new commit works with kexec.
>
> Thanks

Thanks for testing!

Ingo