Re: [PATCH 1/2] reset: add reset-simple to unify socfpga, stm32, and sunxi
From: Philipp Zabel
Date: Wed Mar 08 2017 - 07:37:46 EST
On Wed, 2017-03-08 at 12:05 +0100, Alexandre Torgue wrote:
> Hi Philipp,
> On 03/08/2017 11:19 AM, Andre Przywara wrote:
> > Hi,
> > On 08/03/17 09:54, Philipp Zabel wrote:
> >> Reset operations for simple reset controllers with reset lines that can
> >> be controlled by toggling bits in (mostly) contiguous register ranges
> >> using read-modify-write cycles under a spinlock. So far this covers the
> >> socfpga, stm32, and sunxi drivers.
> > Wow, that looks nice, thanks for that.
> > But can't we go one step further and unify those driver into one file then?
> > And either have different probe functions to cover the different DT
> > requirements or to just have one unified probe checking for the super
> > set of all properties?
> I agree with Andre. It looks nice and it should be a good thing to have
> a common probe inside reset-simple.c
> Maybe only "nresets" and "inverted" DT properties are needed.
Adding DT properties is not an option, as the driver would have to work
with the existing bindings. We could merge them into one file, with a
single probe function that configures different parameters depending on
the of_device_id returned by of_match_device.