Re: [PATCH v2 1/2] net: sched: make default fifo qdiscs appear in the dump

[Eric Dumazet]

On Wed, 2017-03-08 at 13:03 +0100, Jiri Kosina wrote:


> +++ b/net/sched/sch_qfq.c
> @@ -494,6 +494,8 @@ static int qfq_change_class(struct Qdisc *sch, u32 classid, u32 parentid,
>  			goto destroy_class;
>  	}
>  
> +	if (cl->qdisc != &noop_qdisc)
> +		qdisc_hash_add(cl->qdisc, true);


Please move the test in qdisc_hash_add() instead of copy/pasting it all
over the places ?

This is control path, keep it small, thanks !