Re: [PATCH v2 1/1] mm: zswap - Add crypto acomp/scomp framework support

From: Herbert Xu
Date: Thu Mar 09 2017 - 04:41:58 EST

On Wed, Mar 08, 2017 at 12:38:40PM -0500, Dan Streetman wrote:
> It looks like the crypto_scomp interface is buried under
> include/crypto/internal/scompress.h, however that's exactly what zswap
> should be using. We don't need to switch to an asynchronous interface
> that's rather significantly more complicated, and then use it in a
> synchronous way. The crypto_scomp interface should probably be made
> public, not an implementation internal.

No scomp is not meant to be used externally. We provide exactly
one compression interface and it's acomp. acomp can be used
synchronously by setting the CRYPTO_ALG_ASYNC bit in the mask
field when allocating the algorithm.

The existing compression interface will be phased out.

Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page:
PGP Key: