Re: [PATCH] audit: log module name on delete_module

From: Miroslav Benes
Date: Thu Mar 09 2017 - 09:50:37 EST


On Thu, 9 Mar 2017, Richard Guy Briggs wrote:

> Record the module name of a delete_module call.
>
> See: https://github.com/linux-audit/audit-kernel/issues/37
>
> Signed-off-by: Richard Guy Briggs <rgb@xxxxxxxxxx>

Could you improve the changelog, please? I don't think that a link to
a github issue can and should replace it. Proper description and reason of
the change should be in git log.

Thanks,
Miroslav

> ---
> kernel/module.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/kernel/module.c b/kernel/module.c
> index 5432dbe..633f6da 100644
> --- a/kernel/module.c
> +++ b/kernel/module.c
> @@ -943,6 +943,8 @@ SYSCALL_DEFINE2(delete_module, const char __user *, name_user,
> return -EFAULT;
> name[MODULE_NAME_LEN-1] = '\0';
>
> + audit_log_kern_module(name);
> +
> if (mutex_lock_interruptible(&module_mutex) != 0)
> return -EINTR;
>
> --
> 1.7.1
>