Re: [PATCH net-next 04/14] net: dsa: mv88e6xxx: rework ATU Load/Purge
From: Andrew Lunn
Date: Thu Mar 09 2017 - 21:28:00 EST
On Thu, Mar 09, 2017 at 06:33:14PM -0500, Vivien Didelot wrote:
> All Marvell switch chips have an ATU accessed using the same Global (1)
> register layout. Only the handling of the FID differs as more bits were
> necessary to support more and more databases.
> Add and use a fresh documented implementation of the ATU Load/Purge.
This is not really the Linux way of doing something. You don't throw
something away and replace it. You incrementally modify what you have
into something better.
I really wished you had moved the code, unmodified, into
global1_atu.c. Then made lots of easy to review small changes. I
cannot just look at this patch and know it is correct. What i need to
compare against is not in this patch. So it is a lot harder to review.
I will continue this review later...