[PATCH 3.16 044/370] ssb: Fix error routine when fallback SPROM fails

From: Ben Hutchings
Date: Fri Mar 10 2017 - 09:31:30 EST

3.16.42-rc1 review patch. If anyone has any objections, please let me know.


From: Larry Finger <Larry.Finger@xxxxxxxxxxxx>

commit 8052d7245b6089992343c80b38b14dbbd8354651 upstream.

When there is a CRC error in the SPROM read from the device, the code
attempts to handle a fallback SPROM. When this also fails, the driver
returns zero rather than an error code.

Signed-off-by: Larry Finger <Larry.Finger@xxxxxxxxxxxx>
Signed-off-by: Kalle Valo <kvalo@xxxxxxxxxxxxxx>
Signed-off-by: Ben Hutchings <ben@xxxxxxxxxxxxxxx>
drivers/ssb/pci.c | 1 +
1 file changed, 1 insertion(+)

--- a/drivers/ssb/pci.c
+++ b/drivers/ssb/pci.c
@@ -846,6 +846,7 @@ static int ssb_pci_sprom_get(struct ssb_
if (err) {
ssb_warn("WARNING: Using fallback SPROM failed (err %d)\n",
+ goto out_free;
} else {
ssb_dbg("Using SPROM revision %d provided by platform\n",