Re: [PATCH v2 2/8] watchdog: s3c2410: Fix infinite interrupt in soft mode
From: Krzysztof Kozlowski
Date: Sat Mar 11 2017 - 12:36:57 EST
On Sat, Mar 11, 2017 at 07:25:21PM +0200, Krzysztof Kozlowski wrote:
> In soft (no-reboot) mode, the driver self-pings watchdog upon expiration
> of an interrupt. However the interrupt itself was not cleared thus on
> first hit, the system enters infinite interrupt handling loop.
> On Odroid U3 (Exynos4412), when booted with s3c2410_wdt.soft_noboot=1
> argument the console is flooded:
> # killall -9 watchdog
> [ 60.523760] s3c2410-wdt 10060000.watchdog: watchdog timer expired (irq)
> [ 60.536744] s3c2410-wdt 10060000.watchdog: watchdog timer expired (irq)
> Fix this by writing something to the WTCLRINT register to clear the
> interrupt. The register WTCLRINT however appeared in S3C6410 so a new
> watchdog quirk and flavor are needed.
> Signed-off-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx>
> Acked-by: Rob Herring <robh@xxxxxxxxxx>
> .../devicetree/bindings/watchdog/samsung-wdt.txt | 9 +++++----
> drivers/watchdog/s3c2410_wdt.c | 21 ++++++++++++++++++---
> 2 files changed, 23 insertions(+), 7 deletions(-)
This can be ignored, already applied.