Re: [PATCH v1 10/10] staging: iio: gyro: Remove exceptional & on function name

From: Jonathan Cameron
Date: Sat Mar 11 2017 - 13:57:27 EST


On 11/03/17 18:48, Jonathan Cameron wrote:
> On 11/03/17 14:26, simran singhal wrote:
>> Remove & from function pointers to conform to the style found elsewhere
>> in the file. Done using the following semantic patch
>>
>> // <smpl>
>> @r@
>> identifier f;
>> @@
>>
>> f(...) { ... }
>> @@
>> identifier r.f;
>> @@
>>
>> - &f
>> + f
>> // </smpl>
>>
>> Signed-off-by: simran singhal <singhalsimran0@xxxxxxxxx>
> Again, I couldn't identify any other function pointers in this file
> so have amended the patch description to reflect that.
>
> I also added a note that will hopefully prevent anyone seeing
> this patch deciding to send me the several hundred patches it
> 'might' - I haven't checked - take to clean up the whole subsystem.
>
> Thanks for the whole series.
>
> Applied to the togreg branhc of iio.git and pushed out as testing.
I spoke to soon. Something odd going on with kernel.org wrt to my
connection to it at least. Will try to push out again later.

Jonathan
>
> Jonathan
>> ---
>> drivers/staging/iio/gyro/adis16060_core.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/iio/gyro/adis16060_core.c b/drivers/staging/iio/gyro/adis16060_core.c
>> index ab816a2..c9d46e7 100644
>> --- a/drivers/staging/iio/gyro/adis16060_core.c
>> +++ b/drivers/staging/iio/gyro/adis16060_core.c
>> @@ -117,7 +117,7 @@ static int adis16060_read_raw(struct iio_dev *indio_dev,
>> }
>>
>> static const struct iio_info adis16060_info = {
>> - .read_raw = &adis16060_read_raw,
>> + .read_raw = adis16060_read_raw,
>> .driver_module = THIS_MODULE,
>> };
>>
>>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>