Re: [PATCH 2/2] drm/panel: simple: Add support for Winstar WF35LTIACD
From: Rob Herring
Date: Sun Mar 12 2017 - 10:18:07 EST
On Fri, Mar 03, 2017 at 04:21:56PM +0100, Richard Genoud wrote:
> This adds support for the Winstar Display Co. WF35LTIACD 3.5" QVGA TFT
> LCD panel, which can be supported by the simple panel driver.
> Signed-off-by: Richard Genoud <richard.genoud@xxxxxxxxx>
> .../bindings/display/panel/winstar,wf35ltiacd | 7 ++++++
> drivers/gpu/drm/panel/panel-simple.c | 28 ++++++++++++++++++++++
> 2 files changed, 35 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/panel/winstar,wf35ltiacd
> diff --git a/Documentation/devicetree/bindings/display/panel/winstar,wf35ltiacd b/Documentation/devicetree/bindings/display/panel/winstar,wf35ltiacd
> new file mode 100644
> index 000000000000..68408adf239f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/winstar,wf35ltiacd
> @@ -0,0 +1,7 @@
> +Winstar Display Corporation 3.5" QVGA (320x240) TFT LCD panel
> +Required properties:
> +- compatible: should be "winstar,wf35ltiacd"
> +This binding is compatible with the simple-panel binding, which is specified
> +in simple-panel.txt in this directory.
Please specify the power supply(ies). I know a lot of bindings haven't,
but many panels have more than 1 supply and just relying on simple panel
doesn't distinguish whether the panel has 1 supply or you didn't check
and it has more than 1.