Re: [PATCH] drm/i915: annote drop_caches debugfs interface with lockdep
From: Chris Wilson
Date: Sun Mar 12 2017 - 15:59:33 EST
On Sun, Mar 12, 2017 at 08:27:16PM +0100, Daniel Vetter wrote:
> The trouble we have is that we can't really test all the shrinker
> recursion stuff exhaustively in BAT because any kind of thrashing
> stress test just takes too long.
> But that leaves a really big gap open, since shrinker recursions are
> one of the most annoying bugs. Now lockdep already has support for
> checking allocation deadlocks:
> - Direct reclaim paths are marked up with
> lockdep_set_current_reclaim_state() and
> - Any allocation paths are marked with lockdep_trace_alloc().
> If we simply mark up our debugfs with the reclaim annotations, any
> code and locks taken in there will automatically complete the picture
> with any allocation paths we already have, as long as we have a simple
> testcase in BAT which throws out a few objects using this interface.
> Not stress test or thrashing needed at all.
> v2: Need to EXPORT_SYMBOL_GPL to make it compile as a module.
> Cc: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
> Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
> Cc: Ingo Molnar <mingo@xxxxxxxxxx>
> Cc: linux-kernel@xxxxxxxxxxxxxxx
> Reviewed-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> (v1)
> Signed-off-by: Daniel Vetter <daniel.vetter@xxxxxxxxx>
> We want this to validate the i915 shrinker locking in our fast tests
> without thrashing badly (that takes too long, we can only thrash in
> the extended runs). Can you pls take a look and if it's ok ack for
> merging through drm-intel.git?
> Thanks, Daniel
> drivers/gpu/drm/i915/i915_debugfs.c | 2 ++
> kernel/locking/lockdep.c | 2 ++
> 2 files changed, 4 insertions(+)
> diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
> index 82fb005a5e22..0f1d6c4a212b 100644
> --- a/drivers/gpu/drm/i915/i915_debugfs.c
> +++ b/drivers/gpu/drm/i915/i915_debugfs.c
> @@ -4273,11 +4273,13 @@ i915_drop_caches_set(void *data, u64 val)
> if (val & (DROP_RETIRE | DROP_ACTIVE))
> + lockdep_set_current_reclaim_state(GFP_KERNEL);
> if (val & DROP_BOUND)
> i915_gem_shrink(dev_priv, LONG_MAX, I915_SHRINK_BOUND);
> if (val & DROP_UNBOUND)
> i915_gem_shrink(dev_priv, LONG_MAX, I915_SHRINK_UNBOUND);
> + lockdep_clear_current_reclaim_state();
> if (val & DROP_SHRINK_ALL)
Best to move the clear to here.
Chris Wilson, Intel Open Source Technology Centre