Re: [PATCH 22/26] x86/mm: add sync_global_pgds() for configuration with 5-level paging

From: Ingo Molnar
Date: Mon Mar 13 2017 - 03:22:49 EST

* Kirill A. Shutemov <kirill.shutemov@xxxxxxxxxxxxxxx> wrote:

> This basically restores slightly modified version of original
> sync_global_pgds() which we had before foldedl p4d was introduced.

Please read your changelogs, I saw several typos/grammar mistakes in earlier
patches. The one here is:


> + for (address = start; address <= end && address >= start;
> + address += PGDIR_SIZE) {

Please don't address col80 checkpatch warnings by breaking the line in such an
ugly way! Find another method, or just leave it slightly longer than 80 cols.

This one could probably be solved by:


... which is the canonical variable name for such iterations anyway.

> + /* the pgt_lock only for Xen */

Please use whole sentences in comments, and please capitalize them properly.

I.e. here:

/* We acquire the pgt_lock only for Xen: */

> + BUG_ON(pgd_page_vaddr(*pgd)
> + != pgd_page_vaddr(*pgd_ref));

Ugly col80 artifact ...

Please review the rest of the series for similar patterns as well, and please only
post 5-10 patches in the next submission - we'll review and apply them step by