Re: [tpmdd-devel] [PATCH] tpm: Add sysfs interface to show TPM family version
From: Andrew Lunn
Date: Mon Mar 13 2017 - 10:32:15 EST
On Mon, Mar 13, 2017 at 12:54:24PM +0000, Li, Meng wrote:
> > -----Original Message-----
> > From: Jarkko Sakkinen [mailto:jarkko.sakkinen@xxxxxxxxxxxxxxx]
> > Sent: Monday, March 13, 2017 7:54 PM
> > To: Li, Meng
> > Cc: linux-kernel@xxxxxxxxxxxxxxx; peterhuewe@xxxxxx;
> > tpmdd@xxxxxxxxxxxx; jgunthorpe@xxxxxxxxxxxxxxxxxxxx; tpmdd-
> > devel@xxxxxxxxxxxxxxxxxxxxx
> > Subject: Re: [PATCH] tpm: Add sysfs interface to show TPM family version
> > On Mon, Mar 13, 2017 at 05:20:17PM +0800, Meng.Li@xxxxxxxxxxxxx wrote:
> > > From: Limeng <Meng.Li@xxxxxxxxxxxxx>
> > >
> > > So far, there is not a sysfs interface for user space code to check
> > > the TPM family version(TPM1.x or TPM2). So, add a file named
> > > description in /sys/class/tpm/tpmX/ to show it.
> > >
> > > Signed-off-by: Meng Li <Meng.Li@xxxxxxxxxxxxx>
> > > ---
> > Is this the first or which version of the patch is this? Version number and
> > changelog are missing :/
> Hi Jarkko,
> This is the second version of this patch. The first one is reviewed by Peter who give out some good advices.
> It is my first time to submit patch to upstream(main line),
A tip for you then. Wait at least one day between patch versions. That
gives people time to comment on your patches, and you can fix many
different issues at once.
> and I am not very clear with the submitting rule.
A good start is:
> So, could you please give me a template to record the version and changing log?
After the --- write one line per change you made from the previous
version. Also, v3 should also contain the v2 change history etc...
Picking a random example from the web: