Re: [PATCH] eeepc-laptop: Skip unknown key messages 0x50 0x51
From: Andy Shevchenko
Date: Mon Mar 13 2017 - 12:04:56 EST
On Tue, Mar 7, 2017 at 9:27 PM, Dmitry Torokhov
> On Fri, Feb 24, 2017 at 02:01:30PM +0100, Pau Espin Pedrol wrote:
>> >> Dmitry, do we have special events for AC (un)plug? What is the best
>> >> approach in your opinion?
>> > Not route them through input as they not input events would be the best.
>> Is my patch good enough for this or would you recommend doing it another way?
> From input POV your patch makes sense.
Could you give your tag?
>> > I'd look into hooking up power_supply class.
>> Whys is this necessay? All the related information required is already
>> present in my system.
>> I already have two power_supply instances:
>> * /sys/class/power_supply/AC0/ (provided by module "ac"), contains
>> property "online" which is correctly updated to 1 when AC is plugged
>> and 0 when AC is unplugged.
>> * /sys/class/power_supply/BAT0/ (provided by module "battery"),
>> contains property "status" which is correctly updated to "Charging"
>> when AC is plugged and "Discharging" when AC is unplugged.
> If everything is already working then it is not necessary. I was
> trying to say that if it does not quite work, then you shoudl look into
> integrating it better with power supply subsystem, instead of trying to
> shoehorn it into input.
With Best Regards,