Re: [PATCH 00/14] platform/x86: remove sparse_keymap_free() calls

From: Andy Shevchenko
Date: Mon Mar 13 2017 - 12:12:23 EST


On Thu, Mar 9, 2017 at 2:11 PM, MichaÅ KÄpieÅ <kernel@xxxxxxxxxx> wrote:
> Hi everyone,
>
> This patch series removes all uses of sparse_keymap_free() in the x86
> platform driver subsystem due to an upcoming change in
> sparse_keymap_setup() behavior wrt memory management. Specifically,
> sparse_keymap_setup() will use managed memory for the keymap copy it
> creates, which enables it to be automatically freed upon input device
> removal, without the need to explicitly call sparse_keymap_free().
>
> I thought it makes sense to post all these patches as a single series.
> To minimize spamming, only this cover letter is addressed to all the
> maintainers whose drivers are affected by this series, while each of the
> subsequent patches will only be sent to the relevant recipients, plus
> the platform-driver-x86 mailing list and subsystem maintainers.
>
> Darren, Andy, all these patches should only be applied after merging an
> immutable branch called ib/4.10-sparse-keymap-managed from Dmitry
> Torokhov's git tree.

Pushed to testing.

If anyone has objections, please tell me as soon as possible (though
we have still time to remove / revert changes which I hope not the
case here).

> drivers/platform/x86/acer-wmi.c | 5 +----
> drivers/platform/x86/asus-laptop.c | 8 ++------
> drivers/platform/x86/asus-wmi.c | 8 ++------
> drivers/platform/x86/dell-wmi-aio.c | 6 +-----
> drivers/platform/x86/dell-wmi.c | 16 ++++------------
> drivers/platform/x86/eeepc-laptop.c | 8 ++------
> drivers/platform/x86/hp-wmi.c | 5 +----
> drivers/platform/x86/ideapad-laptop.c | 5 +----
> drivers/platform/x86/msi-laptop.c | 14 +++-----------
> drivers/platform/x86/msi-wmi.c | 9 ++-------
> drivers/platform/x86/panasonic-laptop.c | 18 +++---------------
> drivers/platform/x86/topstar-laptop.c | 5 +----
> drivers/platform/x86/toshiba-wmi.c | 5 +----
> drivers/platform/x86/toshiba_acpi.c | 8 ++------
> 14 files changed, 26 insertions(+), 94 deletions(-)
>
> --
> 2.12.0
>



--
With Best Regards,
Andy Shevchenko