Re: [RESEND PATCH] drm/msm: adreno: fix build error without debugfs

From: Emil Velikov
Date: Mon Mar 13 2017 - 14:09:43 EST


On 13 March 2017 at 17:00, Rob Clark <robdclark@xxxxxxxxx> wrote:
> On Mon, Mar 13, 2017 at 12:43 PM, Arnd Bergmann <arnd@xxxxxxxx> wrote:
>> The newly added a5xx support fails to build when debugfs is diabled:
>>
>> drivers/gpu/drm/msm/adreno/a5xx_gpu.c:849:4: error: 'struct msm_gpu_funcs' has no member named 'show'
>> drivers/gpu/drm/msm/adreno/a5xx_gpu.c:849:11: error: 'a5xx_show' undeclared here (not in a function); did you mean 'a5xx_irq'?
>>
>> This adds a missing #ifdef.
>>
>> Fixes: b5f103ab98c7 ("drm/msm: gpu: Add A5XX target support")
>> Cc: stable@xxxxxxxxxxxxxxx
>> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
>
> I thought I had picked this one up already, but I guess my brain was
> playing tricks on me.. I've pushed this to msm-next for now and will
> cherry-pick this over to a -fixes branch when I send fixes for 4.11..
>
Sean sent a similar patch last week. I think he picked it (alongside
others) in drm-misc-fixes.
Haven't checked though ;-)

-Emil