Re: [PATCH] usbnet: smsc95xx: Reduce logging noise

From: David Miller
Date: Mon Mar 13 2017 - 18:32:55 EST

From: Guenter Roeck <linux@xxxxxxxxxxxx>
Date: Fri, 10 Mar 2017 17:45:21 -0800

> An insert/remove stress test generated the following log message sequence.
> Use netdev_dbg() instead of netdev_warn() for the repeating messages
> to reduce logging noise.
> Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx>

The problem I have with changes like this is that outside of your
stress test situation these messages are extremely useful but will
now be hidden making diagnosis of problems more difficult.

Perhaps you can check the error code or some piece of USB device
state to see if there was a disconnect, and elide the log message
in that case specifically.