Re: [PATCH 1/2] dt-bindings: ata: add DT bindings for ahci-dm816 SATA controller
From: Bartosz Golaszewski
Date: Tue Mar 14 2017 - 06:43:55 EST
2017-03-13 18:27 GMT+01:00 Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx>:
> On 03/13/2017 08:08 PM, Bartosz Golaszewski wrote:
>>>> Add DT bindings for the onboard SATA controller present on the DM816x
>>>> Signed-off-by: Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx>
>>>> Documentation/devicetree/bindings/ata/ahci-dm816.txt | 20
>>>> 1 file changed, 20 insertions(+)
>>>> create mode 100644 Documentation/devicetree/bindings/ata/ahci-dm816.txt
>>>> diff --git a/Documentation/devicetree/bindings/ata/ahci-dm816.txt
>>>> new file mode 100644
>>>> index 0000000..b87ed5a
>>>> --- /dev/null
>>>> +++ b/Documentation/devicetree/bindings/ata/ahci-dm816.txt
>>>> @@ -0,0 +1,20 @@
>>>> +Device tree binding for the TI DM816 AHCI SATA Controller
>>>> +Required properties:
>>>> + - compatible: must be "ti,dm816-ahci"
>>>> + - reg: physical base address and size of the register region used by
>>>> + the controller (as defined by the AHCI 1.1 standard)
>>>> + - interrupts: interrupt specifier (refer to the interrupt binding)
>>>> + - clocks: clock specifiers (refer to the clock binding); two clocks
>>> There should be a phandle preceding the clock specifier, all new such
>>> props are different to the old "interrupts" (which had phandle in a
>>> "interrupt-parent" prop).
>> I'm afraid I don't understand - could you point me to an example?
> Have you read Documentation/devicetree/bindings/clock/clock-bindings.txt,
> on clock consumers?
Yes I have. It says:
66 clocks: List of phandle and clock specifier pairs, one pair
67 for each clock input to the device. Note: if the
68 clock provider specifies '0' for #clock-cells, then
69 only the phandle portion of the pair will appear.
> In fact, your own example below doesn't have clock specifiers, only
Since the SATA reference clock specifies 0 for #clock-cells I'll omit
the clock specifier. On the other hand: I'll rephrase the clocks
property description in the bindings for clarity.