Re: [PATCH] pinctrl: rockchip: add irq_enable & irq_disable ops

From: Heiko Stübner
Date: Tue Mar 14 2017 - 11:06:58 EST


Hi Linus,

Am Dienstag, 14. März 2017, 16:03:48 CET schrieb Linus Walleij:
> On Thu, Mar 2, 2017 at 6:56 AM, Jeffy Chen <jeffy.chen@xxxxxxxxxxxxxx>
wrote:
> > Currently we are trying to enable/disable the clk of irq's gpio bank when
> > unmask/mask irq. But the kernel's "lazy disable approach" will skip
> > masking
> > irq when the irq chip doesn't support irq_disable ops.
> >
> > So we may hit this case:
> > irq_enable-> enable clk
> > irq_disable-> noop
> > irq_enable-> enable clk again
> > irq_disable-> noop
> >
> > Signed-off-by: Jeffy Chen <jeffy.chen@xxxxxxxxxxxxxx>
>
> Heiko, can you look at this patch?

This (and all the other pending pinctrl patches) are in my queue, but right
now I'm still hunting rockchip regressions in 4.11-rc, so haven't found the
time to review yet.


Heiko