RE: [PATCH 6/7] megasas: Remove expensive inline from megasas_return_cmd

[Sumit Saxena]

>-----Original Message-----
>From: megaraidlinux.pdl@xxxxxxxxxxxx
>[mailto:megaraidlinux.pdl@xxxxxxxxxxxx] On Behalf Of Andi Kleen
>Sent: Wednesday, March 15, 2017 7:45 AM
>To: akpm@xxxxxxxxxxxxxxxxxxxx
>Cc: linux-kernel@xxxxxxxxxxxxxxx; Andi Kleen;
>megaraidlinux.pdl@xxxxxxxxxxxx
>Subject: [PATCH 6/7] megasas: Remove expensive inline from
>megasas_return_cmd
>
>From: Andi Kleen <ak@xxxxxxxxxxxxxxx>
>
>Remove an inline from a fairly big function that is used often.
>It's unlikely that calling or not calling it makes a lot of difference.
>
>Saves around 8k text in my kernel.
>
>   text    data     bss     dec     hex filename
>9047801 5367568 11116544        25531913        1859609
>vmlinux-before-megasas
>9039417 5367568 11116544        25523529        1857549 vmlinux-megasas
>
>Cc: megaraidlinux.pdl@xxxxxxxxxxxx
>Signed-off-by: Andi Kleen <ak@xxxxxxxxxxxxxxx>
>---
> drivers/scsi/megaraid/megaraid_sas_base.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c
>b/drivers/scsi/megaraid/megaraid_sas_base.c
>index 7ac9a9ee9bd4..55b71de3fb1f 100644
>--- a/drivers/scsi/megaraid/megaraid_sas_base.c
>+++ b/drivers/scsi/megaraid/megaraid_sas_base.c
>@@ -244,7 +244,7 @@ struct megasas_cmd *megasas_get_cmd(struct
>megasas_instance
>  * @instance:		Adapter soft state
>  * @cmd:		Command packet to be returned to free command pool
>  */
>-inline void
>+void
> megasas_return_cmd(struct megasas_instance *instance, struct megasas_cmd
>*cmd)  {
> 	unsigned long flags;

Acked-by: Sumit Saxena <sumit.saxena@xxxxxxxxxxxx>

>--
>2.9.3
>