Re: [PATCH v2] generic syscalls: Wire up statx syscall

From: James Hogan
Date: Wed Mar 15 2017 - 18:28:16 EST


On 13 March 2017 at 14:45, Stafford Horne <shorne@xxxxxxxxx> wrote:
> The new syscall statx is implemented as generic code, so enable it
> for architectures like openrisc which use the generic syscall table.
>
> Fixes: a528d35e8bfcc ("statx: Add a system call to make enhanced file info available")
> Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> Cc: Al Viro <viro@xxxxxxxxxxxxxxxxxx>
> Cc: David Howells <dhowells@xxxxxxxxxx>
> Cc: Catalin Marinas <catalin.marinas@xxxxxxx>
> Cc: Will Deacon <will.deacon@xxxxxxx>
> Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> Signed-off-by: Stafford Horne <shorne@xxxxxxxxx>
> ---
> Change in v2:
> - Add a few more Cc's to get attention of the right people
> - Add a fixes tag for better audit
>
> include/uapi/asm-generic/unistd.h | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/include/uapi/asm-generic/unistd.h b/include/uapi/asm-generic/unistd.h
> index 9b1462e..a076cf1 100644
> --- a/include/uapi/asm-generic/unistd.h
> +++ b/include/uapi/asm-generic/unistd.h
> @@ -730,9 +730,11 @@ __SYSCALL(__NR_pkey_mprotect, sys_pkey_mprotect)
> __SYSCALL(__NR_pkey_alloc, sys_pkey_alloc)
> #define __NR_pkey_free 290
> __SYSCALL(__NR_pkey_free, sys_pkey_free)
> +#define __NR_statx 291
> +__SYSCALL(__NR_statx, sys_statx)
>
> #undef __NR_syscalls
> -#define __NR_syscalls 291
> +#define __NR_syscalls 292

Out of interest, anybody know OTOH which other stat syscalls statx
supersedes (such that they could at some point be disabled by default
in asm-generic for new arches, and implemented in userspace)?

Cheers
--
James Hogan