Re: [PATCH 4/5 v3] ftrace/x86_32: Clean up ftrace_regs_caller

From: Linus Torvalds
Date: Thu Mar 16 2017 - 15:31:07 EST


On Thu, Mar 16, 2017 at 12:24 PM, Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
> popl %ds
> popl %es
> popl %fs
> popl %gs

Do you even need these? Can they be changed by ftrace?

And see the previous email about not touching the original location at
all, adn just duplicating that entry, avoiding all the need for
shuffling. I *really* hope that ftrace doesn't depend on changing the
return %eip on the stack. That would be truly nasty.

Linus