Re: [patch 7/7] x86/pci/mmcfg: Switch to ECAM config mode if possible

From: Thomas Gleixner
Date: Fri Mar 17 2017 - 02:15:36 EST


On Thu, 16 Mar 2017, Andi Kleen wrote:

> > + /*
> > + * The pointer to root_pci_ops has been handed in to ACPI already
> > + * and is already set in the busses.
> > + *
> > + * Switch the functions over to ECAM for all config space accesses.
> > + */
> > + pci_root_ops.read = pci_ecam_read;
> > + pci_root_ops.write = pci_ecam_write;
> > + pr_info("PCI: Switch to ECAM configuration mode\n");
>
> That patch is fine, but it's generally called MMCONFIG (don't know
> where this ECAM term comes from).

ECAM is the official name for the memory mapped configuration mechanism
according to the PCI express specification.

> So please use MMCONFIG or MCFG everywhere, not ECAM.

While I prefer using names which match specifications, I let Bjorn decide
on that one.

Thanks,

tglx