Re: [PATCH v2 1/3] misc: tsl2550: Add OF device ID table

From: Arnd Bergmann
Date: Tue Mar 21 2017 - 09:55:54 EST


On Tue, Mar 21, 2017 at 2:50 PM, Javier Martinez Canillas
<javier@xxxxxxxxxxxxxxx> wrote:
> The driver doesn't have a struct of_device_id table but supported devices
> are registered via Device Trees. This is working on the assumption that a
> I2C device registered via OF will always match a legacy I2C device ID and
> that the MODALIAS reported will always be of the form i2c:<device>.
>
> But this could change in the future so the correct approach is to have an
> OF device ID table if the devices are registered via OF.
>
> Signed-off-by: Javier Martinez Canillas <javier@xxxxxxxxxxxxxxx>

Acked-by: Arnd Bergmann <arnd@xxxxxxxx>