RE: [PATCH v2 4/4] x86/mce: Add AMD SMCA support to SRAO notifier

From: Ghannam, Yazen
Date: Tue Mar 21 2017 - 17:47:48 EST


> -----Original Message-----
> From: Ghannam, Yazen
> Sent: Monday, March 20, 2017 4:27 PM

[...]

> +/* Only support this on SMCA systems and errors logged from a UMC. */
> +static int mce_usable_address_amd(struct mce *m, unsigned long *pfn) {
> + u8 umc;

This should be
int umc;
to match the return value from find_umc_channel() below.

> + u16 nid = cpu_to_node(m->extcpu);
> + u64 addr;
> +
> + if (!mce_flags.smca)
> + return 0;
> +
> + umc = find_umc_channel(m);
> +
> + if (umc < 0 || umc_normaddr_to_sysaddr(m->addr, nid, umc, &addr))
> + return 0;
> +
> + *pfn = addr >> PAGE_SHIFT;
> + return 1;
> +}
> +

Thanks,
Yazen