Re: [PATCHv2 1/2] mfd: cpcap: Add missing include dependencies

From: Tony Lindgren
Date: Wed Mar 22 2017 - 11:57:42 EST


* Pavel Machek <pavel@xxxxxx> [170322 02:29]:
> On Wed 2017-03-22 01:09:11, Sebastian Reichel wrote:
> > This fixes compilation for files, that try to include the
> > cpcap header in alphabetically sorted #include lists.
> >
> > Signed-off-by: Sebastian Reichel <sre@xxxxxxxxxx>
>
> Acked-by: Pavel Machek <pavel@xxxxxx>

Hmm I wonder why I never ran into this so far. No objections
to the patch though if it fixes the issue with all the necessary
headers included.

Regards,

Tony


> > ---
> > This patch is new, since PATCHv1 did not order the includes
> > in the led driver alphabetically.
> > ---
> > include/linux/mfd/motorola-cpcap.h | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/include/linux/mfd/motorola-cpcap.h b/include/linux/mfd/motorola-cpcap.h
> > index 7629e0d24d26..b8916953a537 100644
> > --- a/include/linux/mfd/motorola-cpcap.h
> > +++ b/include/linux/mfd/motorola-cpcap.h
> > @@ -14,6 +14,9 @@
> > * published by the Free Software Foundation.
> > */
> >
> > +#include <linux/device.h>
> > +#include <linux/regmap.h>
> > +
> > #define CPCAP_VENDOR_ST 0
> > #define CPCAP_VENDOR_TI 1
> >
>
> --
> (english) http://www.livejournal.com/~pavelmachek
> (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html