Re: [PATCH 3/4] RAS: Add a Corrected Errors Collector

From: Borislav Petkov
Date: Wed Mar 22 2017 - 15:27:30 EST


On Wed, Mar 22, 2017 at 12:00:25PM -0700, Luck, Tony wrote:
> You also need to check that bit 61 of m->status is zero here.
> The collector is hiding uncorrected errors too.

Good catch.

I think I wanna do something like this:

if (memory_error(m) && !(m->status & MCI_STATUS_UC) ...

as we want to make sure we're looking at a memory error first and then
decide on severity.

Alternatively I could stick that logic in another helper called
correctable_memory_error() or so but I don't have a strong preference.

Thanks.

--
Regards/Gruss,
Boris.

ECO tip #101: Trim your mails when you reply.
--