Re: [PATCH] staging: media: atomisp: remove ifdef around HMM_BO_ION

From: Greg Kroah-Hartman
Date: Fri Mar 24 2017 - 09:47:37 EST


On Fri, Mar 24, 2017 at 02:20:24PM +0100, Arnd Bergmann wrote:
> The revert reintroduced a build failure without CONFIG_ION:
>
> media/atomisp/pci/atomisp2/hmm/hmm.c:52:2: error: excess elements in array initializer [-Werror]
> media/atomisp/pci/atomisp2/hmm/hmm.c:52:2: note: (near initialization for 'hmm_bo_type_strings')
>
> We should really be able to build in any configuration, so this tries a
> different fix to make sure the symbol is defined.
>
> Fixes: 9ca98bd07748 ("Revert "staging: media: atomisp: fill properly hmm_bo_type_strings when ION is disabled"")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> ---
> drivers/staging/media/atomisp/pci/atomisp2/include/hmm/hmm_bo.h | 2 --
> 1 file changed, 2 deletions(-)

Ugh, Alan, what's going on here, I thought you fixed this?

totally confused,

greg k-h