Re: [PATCH v7 9/9] media: venus: enable building of Venus video driver

From: Stanimir Varbanov
Date: Fri Mar 24 2017 - 11:31:02 EST


Thanks for the comments!

On 03/24/2017 04:49 PM, Hans Verkuil wrote:
> On 03/13/17 17:37, Stanimir Varbanov wrote:
>> This adds Venus driver Makefile and changes v4l2 platform
>> Makefile/Kconfig in order to enable building of the driver.
>>
>> Signed-off-by: Stanimir Varbanov <stanimir.varbanov@xxxxxxxxxx>
>> ---
>> drivers/media/platform/Kconfig | 14 ++++++++++++++
>> drivers/media/platform/Makefile | 2 ++
>> drivers/media/platform/qcom/venus/Makefile | 11 +++++++++++
>> 3 files changed, 27 insertions(+)
>> create mode 100644 drivers/media/platform/qcom/venus/Makefile
>>
>> diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kconfig
>> index 53f6f12bff0d..8a6c3d664307 100644
>> --- a/drivers/media/platform/Kconfig
>> +++ b/drivers/media/platform/Kconfig
>> @@ -447,6 +447,20 @@ config VIDEO_TI_VPE_DEBUG
>> ---help---
>> Enable debug messages on VPE driver.
>>
>> +config VIDEO_QCOM_VENUS
>> + tristate "Qualcomm Venus V4L2 encoder/decoder driver"
>> + depends on VIDEO_DEV && VIDEO_V4L2 && HAS_DMA
>
> Can this also depend on COMPILE_TEST? And if so, please make sure it compile on both
> a 32 and 64 bit environment to shake out any compiler warnings.
>

yes I can add COMPILE_TEST, at least on -next it should be fine.

--
regards,
Stan