Re: [PATCH v7 5/9] media: venus: vdec: add video decoder files

[Hans Verkuil]

On 27/03/17 04:18, Nicolas Dufresne wrote:
> Le dimanche 26 mars 2017 Ã 00:30 +0200, Stanimir Varbanov a Ãcrit :
>>>> +            vb->planes[0].data_offset = data_offset;
>>>> +            vb->timestamp = timestamp_us * NSEC_PER_USEC;
>>>> +            vbuf->sequence = inst->sequence++;
>>>
>>> timestamp and sequence are only set for CAPTURE, not OUTPUT. Is
>>> that correct?
>>
>> Correct. I can add sequence for the OUTPUT queue too, but I have no idea 
>> how that sequence is used by userspace.
> 
> Neither GStreamer or Chromium seems to use it. What does that number
> means for a m2m driver ? Does it really means something ?

It can be used to detect dropped frame (the sequence counter will skip in that
case).

Unlikely to happen for m2m devices, and most apps ignore it as well. But you
still need to fill it in, it's a V4L2 requirement.

Regards,

	Hans