Re: [RFC PATCH v0.2] PCI: Add support for tango PCIe host bridge

From: Thomas Gleixner
Date: Mon Mar 27 2017 - 10:46:39 EST


On Mon, 27 Mar 2017, Mason wrote:
> On 24/03/2017 19:22, Marc Zyngier wrote:
>
> > You cannot directly use a pointer to a u32 in any of the bitmap
> > operations. You need to copy the value to an unsigned long, and
> > apply the bitmap op on that.
>
> On my platform, find_first_zero_bit() resolves to
>
> int _find_first_zero_bit_le(const void * p, unsigned size);
>
> If the underlying implementation actually expects an unsigned long
> pointer, should the function prototype be changed?

Errm? Why are you worrying about the underlying implementations?

find_first_zero_bit() is what you are supposed to use in your code. And
that explicitely takes a unsigned long pointer.

Thanks,

tglx