Re: [PATCH v4 1/4] pinctrl: rockchip: remove unnecessary locking

From: Linus Walleij
Date: Tue Mar 28 2017 - 05:17:29 EST


On Thu, Mar 23, 2017 at 11:59 AM, John Keeping <john@xxxxxxxxxxxx> wrote:

> regmap_update_bits does its own locking and everything else accessed
> here is a local variable so there is no need to lock around it.
>
> Signed-off-by: John Keeping <john@xxxxxxxxxxxx>
> Reviewed-by: Heiko Stuebner <heiko@xxxxxxxxx>
> Tested-by: Heiko Stuebner <heiko@xxxxxxxxx>
> ---
> v3: unchanged
> v2.1:
> - Remove RK2928 locking in rockchip_set_pull()
> v2:
> - Also remove locking in rockchip_set_schmitt()

Patch applied.

Yours,
Linus Walleij