Re: [PATCH v3 4/7] arm: dts: r7s72100: Add pin controller node

From: jacopo
Date: Wed Mar 29 2017 - 09:26:39 EST


Hi Chris,

On Mon, Mar 27, 2017 at 05:12:04PM +0000, Chris Brandt wrote:
> Hi Jacopo,
>
>
> On Friday, March 24, 2017, Jacopo Mondi
> > + pinctrl: pinctrl@fcfe3000 {
> > + compatible = "renesas,r7s72100-ports";
> > +
> > + #pinctrl-cells = <1>;
> > +
> > + reg = <0xfcfe3000 0x42C0>;
>
> Out of curiosity, why did you change this from 0x4248 to 0x42C0?
>
> In your update for renesas,rza1-pinctrl.txt, for the 'Example', you changed it from 0x4248 to 0x4230 (which Geert pointed out makes more sense), but then in the actual DT file you changed it to 0x42C0. Typo?
>

Yes, type.
Or inability to perform basic mathematical operations.
Not sure yet.

Thanks for spotting this :)
j


>
> Chris
>