Re: [PATCH] HID: asus: Add missing Fn key maps on ASUS E200H

From: Jiri Kosina
Date: Thu Mar 30 2017 - 05:19:29 EST


On Mon, 27 Mar 2017, Takashi Iwai wrote:

> The mapping of a few Fn combo keys seems missing since they are vendor
> specific usage page (0xff31). Add the mapping manually for sleep
> (Fn-F1), rfkill (Fn-F2), brightness down (Fn-F5), brightness up
> (Fn-F6), display toggle (Fn-F7), and touchpad toggle (Fn-F9).
> For the display toggle and the touchpad toggle, KEY_SCREENLOCK and
> KEY_F21 are assigned as convention.
>
> The monitor switch (Fn-F8), and audio volume down / up /mute (Fn-F10,
> F11, F12) work as is without the extra mapping, thus left as is.
>
> Signed-off-by: Takashi Iwai <tiwai@xxxxxxx>

I think is has already been covered by Matjaz's (adding to CC) patches in
hid.git#for-4.12/asus. Could you please check whether it covers everything
your patch did?

Thanks,

--
Jiri Kosina
SUSE Labs