Re: [PATCH 2/2] extcon: Add new extcon_register_notifier_all() to monitor all external connectors

From: Andy Shevchenko
Date: Thu Mar 30 2017 - 07:09:43 EST


On Thu, Mar 30, 2017 at 1:56 PM, Chanwoo Choi <cw00.choi@xxxxxxxxxxx> wrote:
> On 2017ë 03ì 30ì 19:42, Andy Shevchenko wrote:
>> On Thu, Mar 30, 2017 at 12:24 PM, Chanwoo Choi <cw00.choi@xxxxxxxxxxx> wrote:
>>> On 2017ë 03ì 30ì 18:05, Andy Shevchenko wrote:
>>>> On Thu, Mar 30, 2017 at 11:39 AM, Chanwoo Choi <cw00.choi@xxxxxxxxxxx> wrote:

>>>>> +/**
>>>>> + * extcon_register_notifier_all() - Register a notifier block to get the noti
>>>>> + * of the status change for all supported external
>>>>> + * connectors from extcon.
>>>>> + * @edev: the extcon device that has the external connecotr.
>>>>> + * @nb: a notifier block to be registered.
>>>>> + *
>>>>> + * Note that the second parameter given to the callback of nb (val) is
>>>>> + * the current state and third parameter is the edev pointer.
>>>>> + */

> If you metioned the following guide on Line 111
> in the Documentation/doc-guide/kernel-doc.rst,

Yes, that's one.

> OK. I'll modify it.

Thanks.

>
> Example kernel-doc function comment::
>
> /**
> * foobar() - Brief description of foobar.
> * @arg: Description of argument of foobar.
> *
> * Longer description of foobar.
> *
> * Return: Description of return value of foobar.
> */
> int foobar(int arg)
>
> --
> Best Regards,
> Chanwoo Choi
> Samsung Electronics



--
With Best Regards,
Andy Shevchenko