Re: [PATCH net v2] openvswitch: Fix ovs_flow_key_update()

From: David Miller
Date: Sat Apr 01 2017 - 15:18:18 EST


From: Yi-Hung Wei <yihung.wei@xxxxxxxxx>
Date: Thu, 30 Mar 2017 12:36:03 -0700

> ovs_flow_key_update() is called when the flow key is invalid, and it is
> used to update and revalidate the flow key. Commit 329f45bc4f19
> ("openvswitch: add mac_proto field to the flow key") introduces mac_proto
> field to flow key and use it to determine whether the flow key is valid.
> However, the commit does not update the code path in ovs_flow_key_update()
> to revalidate the flow key which may cause BUG_ON() on execute_recirc().
> This patch addresses the aforementioned issue.
>
> Fixes: 329f45bc4f19 ("openvswitch: add mac_proto field to the flow key")
> Signed-off-by: Yi-Hung Wei <yihung.wei@xxxxxxxxx>

Applied and queued up for -stable, thanks.