Re: [PATCH v2 4/5] serial: split generic UART driver helper functions into a separate file

From: Nicolas Pitre
Date: Sun Apr 02 2017 - 11:45:12 EST


On Sun, 2 Apr 2017, Andy Shevchenko wrote:

> On Sun, Apr 2, 2017 at 1:21 AM, Nicolas Pitre <nicolas.pitre@xxxxxxxxxx> wrote:
> > This contains code that is common between serial_core.c and the
> > minitty code to come. Mainly helper functions used by UART drivers.
>
>
> I have two questions:
> - why minitty (what is that by the way?) can't use serial_core.c as a library?

See patch 5/5. It is a compatible replacement for serial_core.c and the
entire TTY layer collapsed into the smallest code possible, and the
result is itself smaller than serial_core.c alone.

> - does -M -C help to make this diff shorter?

No it doesn't. Maybe I should have mentioned that there is no functional
change resulting from this patch.


Nicolas